Fix PR Build: trigger on ready_for_review#5
Closed
ncipollina wants to merge 1 commit into
Closed
Conversation
…pened pull_request without an explicit types: list only fires on opened, synchronize, and reopened - not ready_for_review. Combined with the reusable workflow itself skipping draft PRs, a PR opened as draft and later marked ready (with no new commit) would never get built. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Author
|
Closing — folded into PR #4 to keep this consolidated into one PR instead of scattered across branches. Same fix (types: ready_for_review), same commit content. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_requestwithout explicittypes:only fires onopened/synchronize/reopened, notready_for_review. Combined with the reusable workflow itself skipping draft PRs, a draft PR later marked ready (no new commit) would never get built.types: [opened, synchronize, reopened, ready_for_review]to the trigger.Test plan
opened, same path as before)🤖 Generated with Claude Code